viirya commented on a change in pull request #23942: [SPARK-27033][SQL]Add Optimize rule RewriteArithmeticFiltersOnIntOrLongColumn URL: https://github.com/apache/spark/pull/23942#discussion_r262394799
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteArithmeticFiltersOnIntOrLongColumn.scala ########## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import org.apache.spark.sql.catalyst.expressions._ +import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.types.{DataType, IntegerType, LongType} + +/** + * Rewrite arithmetic filters on int or long column to its equivalent form, + * leaving attribute alone in one side, so that we can push it down to + * parquet or other file format. + * For example, this rule can optimize + * {{{ + * SELECT * FROM table WHERE i + 3 = 5 + * }}} + * to + * {{{ + * SELECT * FROM table WHERE i = 5 - 3 + * }}} + * when i is Int or Long, and then other rules will further optimize it to + * {{{ + * SELECT * FROM table WHERE i = 2 + * }}} + */ +object RewriteArithmeticFiltersOnIntOrLongColumn extends Rule[LogicalPlan] with PredicateHelper { Review comment: Is this restrictive to Filter only? Looks like it rewrites all qualified expressions in all logical plan. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
