squito commented on a change in pull request #23871: [SPARK-23433][SPARK-25250]
[CORE] Later created TaskSet should learn about the finished partitions
URL: https://github.com/apache/spark/pull/23871#discussion_r262569311
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala
##########
@@ -124,7 +124,8 @@ class FakeTaskScheduler(sc: SparkContext, liveExecutors:
(String, String)* /* ex
}
}
- override def taskSetFinished(manager: TaskSetManager): Unit =
finishedManagers += manager
+ override def taskSetFinished(manager: TaskSetManager)
+ : Unit = finishedManagers += manager
Review comment:
if this really needs to be multiline (though I dont' think it does), be sure
to use multi-line def and wrap the body in braces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
