cloud-fan commented on a change in pull request #23961: [SPARK-27049][SQL] Support handling partition values in the abstraction of file source V2 URL: https://github.com/apache/spark/pull/23961#discussion_r262577237
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/PartitionRecordReader.scala ########## @@ -29,13 +29,3 @@ class PartitionRecordReader[T]( override def close(): Unit = rowReader.close() } - -class PartitionRecordReaderWithProject[X, T]( Review comment: it's just different ways to abstract the code: 1) add common methods in the parent class 2) create util classes. In this case I feel 2) is better, because the added methods in the parent class are not symmetrical. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
