cloud-fan commented on a change in pull request #23981: [SPARK-27064][SS]
create StreamingWrite at the beginning of streaming execution
URL: https://github.com/apache/spark/pull/23981#discussion_r262583789
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
##########
@@ -585,7 +585,7 @@ abstract class StreamExecution(
options: Map[String, String],
inputPlan: LogicalPlan): StreamingWrite = {
val writeBuilder = table.newWriteBuilder(new
DataSourceOptions(options.asJava))
- .withQueryId(runId.toString)
+ .withQueryId(id.toString)
Review comment:
this is an unrelated change, but it was obviously a mistake: the sink
doesn't care about the `runId` which gets changed after query restart. The sink
needs the `id` which is reliable across the life cycle of the stream query.
No builtin streaming sinks use this id, so this is for future-proof.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
