dongjoon-hyun commented on a change in pull request #23928: [SPARK-27023][K8S]
Make k8s client timeouts configurable
URL: https://github.com/apache/spark/pull/23928#discussion_r262602725
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
##########
@@ -63,6 +67,8 @@ private[spark] object SparkKubernetesClientFactory extends
Logging {
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_KEY_FILE_CONF_SUFFIX")
val clientCertFile = sparkConf
.getOption(s"$kubernetesAuthConfPrefix.$CLIENT_CERT_FILE_CONF_SUFFIX")
+ val requestTimeout = clientType.requestTimeout(sparkConf)
+ val connectionTimeout = clientType.connectionTimeout(sparkConf)
Review comment:
Let's remove these variables since this used only once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
