vanzin commented on a change in pull request #23939: [SPARK-27019]
[webUI]onJobStart happens after onExecutionEnd shouldn't overwrite kvstore
URL: https://github.com/apache/spark/pull/23939#discussion_r262652491
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
##########
@@ -77,7 +77,28 @@ class SQLAppStatusListener(
val executionId = executionIdString.toLong
val jobId = event.jobId
- val exec = getOrCreateExecution(executionId)
+ val exec = Option(liveExecutions.get(executionId))
+ .orElse {
+ try {
+ // Should not overwrite the kvstore with new entry, if it already
has the SQLExecution
+ // data corresponding to the execId.
+ val sqlStoreData = kvstore.read(classOf[SQLExecutionUIData],
executionId)
+ val executionData = new LiveExecutionData(executionId)
+ executionData.description = sqlStoreData.description
+ executionData.details = sqlStoreData.details
+ executionData.physicalPlanDescription =
sqlStoreData.physicalPlanDescription
+ executionData.metrics = sqlStoreData.metrics
+ executionData.submissionTime = sqlStoreData.submissionTime
+ executionData.completionTime = sqlStoreData.completionTime
+ executionData.jobs = sqlStoreData.jobs
+ executionData.stages = sqlStoreData.stages
+ executionData.metricsValues = sqlStoreData.metricValues
+ executionData.endEvents = sqlStoreData.endEvents.getOrElse(0)
Review comment:
You don't need to store `endEvents`, do you? Can't can just set it to
`sqlStoreData.jobs.size + 1`?
Otherwise the object wouldn't have been removed from `liveExecutions`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
