wypoon commented on a change in pull request #23767: [SPARK-26329][CORE][WIP]
Faster polling of executor memory metrics.
URL: https://github.com/apache/spark/pull/23767#discussion_r262708020
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala
##########
@@ -172,7 +172,19 @@ private[spark] class EventLoggingListener(
override def onTaskGettingResult(event: SparkListenerTaskGettingResult):
Unit = logEvent(event)
- override def onTaskEnd(event: SparkListenerTaskEnd): Unit = logEvent(event)
+ override def onTaskEnd(event: SparkListenerTaskEnd): Unit = {
+ logEvent(event)
+ if (shouldLogStageExecutorMetrics) {
+ val k1 = (event.stageId, event.stageAttemptId)
+ liveStageExecutorMetrics.foreach { case (k2, peakExecutorMetrics) =>
+ if (k1 == k2) {
Review comment:
You're right, that would be simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
