dilipbiswal opened a new pull request #23982: [SQL][MINOR] Reconcile the join 
type support between data frame and sql interface
URL: https://github.com/apache/spark/pull/23982
 
 
   ## What changes were proposed in this pull request?
   Currently in the grammar file, we have the joinType rule defined as 
following : 
   ```
   joinType
       : INNER?
      ....
      ....
       | LEFT SEMI
       | LEFT? ANTI
       ;
   ```
   The keyword LEFT is optional for ANTI join even though its not optional for 
SEMI join. When
   using data frame interface join type "anti" is not allowed. The allowed 
types are "left_anti" or 
   "leftanti" for anti joins. In this PR, i am making the LEFT keyword 
mandatory for ANTI joins so 
   it aligns better with the LEFT SEMI join in the grammar file and also the 
join types allowed from dataframe api.
   
   Another option is to make LEFT optional for SEMI join in .g4 and add "semi" 
and "anti" join types from dataframe. 
   
   I have not opened any JIRA for this as probably we may need some discussion 
to see if
   we are going to address this or not.
   
   ## How was this patch tested?
   Modified the join type tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to