gagafunctor opened a new pull request #23983: [SPARK-26881][core] Heuristic for tree aggregate depth URL: https://github.com/apache/spark/pull/23983 Changes proposed: - Adding method to compute treeAggregate depth required to avoid exceeding driver max result size (first commit) - Using it in the computation of grammian of RowMatrix (second commit) Tests: - Unit Test wise, one unit test checking the behavior of the depth computation method - Tested at scale on hadoop cluster by doing PCA on a large dataset (needed depth 3 to succeed) Debatable choice: I'm not sure if RDD API is the right place to put the depth computation method. The advantage of it is that it allows to access driver max result size, and rdd number of partitions, to set default arguments for the method. Semantically, such a method might belong to something like org.apache.spark.util.Utils though.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
