SongYadong commented on a change in pull request #23942: [SPARK-27033][SQL]Add
Optimize rule RewriteArithmeticFiltersOnIntOrLongColumn
URL: https://github.com/apache/spark/pull/23942#discussion_r262862755
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
##########
@@ -344,8 +344,9 @@ class JDBCSuite extends QueryTest
"WHERE (THEID > 0 AND TRIM(NAME) = 'mary') OR (NAME = 'fred')")
assert(df2.collect.toSet === Set(Row("fred", 1), Row("mary", 2)))
- assert(checkNotPushdown(sql("SELECT * FROM foobar WHERE (THEID + 1) <
2")).collect().size == 0)
- assert(checkNotPushdown(sql("SELECT * FROM foobar WHERE (THEID + 2) !=
4")).collect().size == 2)
+ // SPARK-27033: Add Optimize rule RewriteArithmeticFiltersOnIntOrLongColumn
+ assert(checkPushdown(sql("SELECT * FROM foobar WHERE (THEID + 1) <
2")).collect().size == 0)
+ assert(checkPushdown(sql("SELECT * FROM foobar WHERE (THEID + 2) !=
4")).collect().size == 2)
Review comment:
Is "!=" also supported? The PR description only mentions "=, >=, <=, >, <".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
