srowen commented on a change in pull request #23976: [SPARK-27057][SQL] Common
trait for limit exec operators
URL: https://github.com/apache/spark/pull/23976#discussion_r262981304
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala
##########
@@ -70,7 +78,7 @@ object BaseLimitExec {
* Helper trait which defines methods that are shared by both
* [[LocalLimitExec]] and [[GlobalLimitExec]].
*/
-trait BaseLimitExec extends UnaryExecNode with CodegenSupport {
+trait BaseLimitExec extends LimitExec with CodegenSupport {
val limit: Int
Review comment:
Does this need `override` now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
