Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/3431#discussion_r21950698
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala ---
@@ -49,6 +48,15 @@ private[sql] class DDLParser extends
StandardTokenParsers with PackratParsers wi
protected implicit def asParser(k: Keyword): Parser[String] =
lexical.allCaseVersions(k.str).map(x => x : Parser[String]).reduce(_ |
_)
+ protected val STRING = Keyword("STRING")
+ protected val SHORT = Keyword("SHORT")
+ protected val DOUBLE = Keyword("DOUBLE")
+ protected val BOOLEAN = Keyword("BOOLEAN")
+ protected val BYTE = Keyword("BYTE")
+ protected val FLOAT = Keyword("FLOAT")
+ protected val INT = Keyword("INT")
+ protected val INTEGER = Keyword("INTEGER")
+ protected val LONG = Keyword("LONG")
--- End diff --
IMO we should follow Hive here. I don't think it's that confusing. I would
actually start by doing only the Hive types and not SHORT or BYTE in order to
make it clearer to users. See
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types for what
they are called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
