MaxGekk commented on a change in pull request #23169: [SPARK-26103][SQL] Limit
the length of debug strings for query plans
URL: https://github.com/apache/spark/pull/23169#discussion_r263123532
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
##########
@@ -119,4 +133,21 @@ object StringUtils {
result.toString
Review comment:
Actually `result` can potentially allocate much more memory than it really
needed for `strings`. The `length` summarizes sizes of all appended strings
even such strings weren't appended, and the line above: `val result = new
java.lang.StringBuilder(length)` could cause OOM which you are trying to avoid
in the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
