vanzin commented on a change in pull request #23169: [SPARK-26103][SQL] Limit 
the length of debug strings for query plans
URL: https://github.com/apache/spark/pull/23169#discussion_r263126339
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
 ##########
 @@ -119,4 +133,21 @@ object StringUtils {
       result.toString
 
 Review comment:
   The `.toString` will allocate a new char array and trim it down to size. So 
you wouldn't hold on to that extra memory.
   
   But yeah there's a little bit of waste here which should be easy to fix, but 
not critical.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to