Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/1290#issuecomment-67275869
  
    The optimizer parameter doesn't have to be a string.  It could be an 
optimizer type as in GeneralizedLinearAlgorithm.  The optimizer type can store 
whatever parameters it needs.  This is a more modular setup than separate 
train() methods or passing strings; it won't require new code in ANN if a new 
optimizer is added.
    
    If you want to rule out certain optimizers, then doing a match-case on the 
optimizer type would be reasonable (in a setOptimizer() method in ANN).
    
    How does that sound?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to