HyukjinKwon commented on a change in pull request #23977: [SPARK-26923][SQL][R]
Refactor ArrowRRunner and RRunner to share one BaseRRunner
URL: https://github.com/apache/spark/pull/23977#discussion_r263335432
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/r/ArrowRRunner.scala
##########
@@ -202,14 +175,17 @@ class ArrowRRunner(
// Likewise, there looks no way to send each batch in streaming
format via socket
// connection. See ARROW-4512.
// So, it reads the whole Arrow streaming-formatted binary at
once for now.
- val in = new
ByteArrayReadableSeekableByteChannel(readByteArrayData(length))
+ val buffer = new Array[Byte](length)
Review comment:
Just realised that `readByteArrayData` is only two lines, and thought it's
better to put all reading related logics from RRunner into `RRunner`'s
`ReaderIterator` in `newReaderIterator`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
