maropu commented on a change in pull request #23942: [SPARK-27033][SQL]Add Optimize rule RewriteArithmeticFiltersOnIntOrLongColumn URL: https://github.com/apache/spark/pull/23942#discussion_r263376060
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteArithmeticFiltersOnIntOrLongColumn.scala ########## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.optimizer + +import org.apache.spark.sql.catalyst.expressions._ +import org.apache.spark.sql.catalyst.plans.logical.{Filter, LogicalPlan} +import org.apache.spark.sql.catalyst.rules.Rule +import org.apache.spark.sql.types.{DataType, IntegerType, LongType} + +/** + * Rewrite arithmetic filters on int or long column to its equivalent form, + * leaving attribute alone in one side, so that we can push it down to + * parquet or other file format. Review comment: nit: how about this? ``` /** * Rewrite arithmetic filters on an integral-type (e.g., int and long) column to its equivalent * form, leaving attribute alone in a left side, so that we can push it down to * datasources (e.g., Parquet and ORC). * * For example, this rule can optimize a query as follows: * {{{ * SELECT * FROM table WHERE i + 3 = 5 * ==> SELECT * FROM table WHERE i = 5 - 3 * }}} * * Then, the [[ConstantFolding]] rule will further optimize it as follows: * {{{ * SELECT * FROM table WHERE i = 2 * }}} * * Note: * 1. This rule supports `Add` and `Subtract` in arithmetic expressions. * 2. This rule supports `=`, `>=`, `<=`, `>`, `<`, and `!=` in comparators. * 3. This rule supports `INT` and `LONG` types only. It doesn't support `FLOAT` or `DOUBLE` * because of precision issues. */ ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
