srowen commented on a change in pull request #23983: [SPARK-26881][core]
Heuristic for tree aggregate depth
URL: https://github.com/apache/spark/pull/23983#discussion_r263461813
##########
File path:
mllib/src/test/scala/org/apache/spark/mllib/linalg/distributed/RowMatrixSuite.scala
##########
@@ -101,6 +101,14 @@ class RowMatrixSuite extends SparkFunSuite with
MLlibTestSparkContext {
}
}
+ test("getTreeAggregateIdealDepth") {
+ val rowMat = new RowMatrix(sc.emptyRDD[Vector])
+ val driverResultSizeInMb = 10000
+ val nbPartitions = 10000
+ assert(rowMat.getTreeAggregateIdealDepth(99, nbPartitions,
driverResultSizeInMb) == 2)
Review comment:
Nit: use `===` to trigger the scalatest macro that will print a better error
if this check fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
