HeartSaVioR commented on a change in pull request #23908: [SPARK-27001][SQL]
Refactor "serializerFor" method between ScalaReflection and JavaTypeInference
URL: https://github.com/apache/spark/pull/23908#discussion_r263583167
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -387,38 +383,28 @@ object ScalaReflection extends ScalaReflection {
private def serializerFor(
inputObject: Expression,
tpe: `Type`,
- walkedTypePath: Seq[String],
+ walkedTypePath: WalkedTypePath,
seenTypeSet: Set[`Type`] = Set.empty): Expression =
cleanUpReflectionObjects {
def toCatalystArray(input: Expression, elementType: `Type`): Expression = {
dataTypeFor(elementType) match {
case dt: ObjectType =>
val clsName = getClassNameFromType(elementType)
- val newPath = s"""- array element class: "$clsName"""" +:
walkedTypePath
- MapObjects(serializerFor(_, elementType, newPath, seenTypeSet),
input, dt)
+ val newPath = walkedTypePath.recordArray(clsName)
+ createSerializerForMapObjects(input, dt,
+ serializerFor(_, elementType, newPath, seenTypeSet))
case dt @ (BooleanType | ByteType | ShortType | IntegerType |
LongType |
FloatType | DoubleType) =>
val cls = input.dataType.asInstanceOf[ObjectType].cls
if (cls.isArray && cls.getComponentType.isPrimitive) {
- StaticInvoke(
- classOf[UnsafeArrayData],
- ArrayType(dt, false),
- "fromPrimitiveArray",
- input :: Nil,
- returnNullable = false)
+ createSerializerForPrimitiveArray(input, dt)
Review comment:
Raised PR: https://github.com/apache/spark/pull/24015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
