squito commented on a change in pull request #23453: [SPARK-26089][CORE] Handle
corruption in large shuffle blocks
URL: https://github.com/apache/spark/pull/23453#discussion_r263599738
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -571,7 +582,8 @@ final class ShuffleBlockFetcherIterator(
}
}
- private def throwFetchFailedException(blockId: BlockId, address:
BlockManagerId, e: Throwable) = {
+ private[storage] def throwFetchFailedException(
+ blockId: BlockId, address: BlockManagerId, e: Throwable) = {
Review comment:
nit: if the method declaration is multi-line, each arg on its own line. And
this method should have had a return type in the first place (probably my
fault, oops)
```scala
private[storage] def throwFetchFailedException(
blockId: BlockId,
address: BlockManagerId,
e: Throwable): Unit = {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
