dilipbiswal commented on a change in pull request #23982: [SPARK-27096][SQL]
Reconcile the join types between data frame and sql interface
URL: https://github.com/apache/spark/pull/23982#discussion_r263666552
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
##########
@@ -470,9 +470,19 @@ class DatasetSuite extends QueryTest with
SharedSQLContext {
assert(e1.contains("Invalid join type in joinWith: " + LeftSemi.sql))
val e2 = intercept[AnalysisException] {
+ ds1.joinWith(ds2, $"a.value" === $"b.value", "semi")
+ }.getMessage
+ assert(e2.contains("Invalid join type in joinWith: " + LeftSemi.sql))
+
+ val e3 = intercept[AnalysisException] {
ds1.joinWith(ds2, $"a.value" === $"b.value", "left_anti")
}.getMessage
- assert(e2.contains("Invalid join type in joinWith: " + LeftAnti.sql))
+ assert(e3.contains("Invalid join type in joinWith: " + LeftAnti.sql))
+
+ val e4 = intercept[AnalysisException] {
+ ds1.joinWith(ds2, $"a.value" === $"b.value", "semi")
Review comment:
@cloud-fan Yeah.. will change. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
