dongjoon-hyun commented on a change in pull request #24025: [SPARK-27106][SQL]
merge CaseInsensitiveStringMap and DataSourceOptions
URL: https://github.com/apache/spark/pull/24025#discussion_r263855465
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -208,18 +209,19 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
source = provider, conf = sparkSession.sessionState.conf)
val pathsOption = {
val objectMapper = new ObjectMapper()
- DataSourceOptions.PATHS_KEY ->
objectMapper.writeValueAsString(paths.toArray)
+ "path" -> objectMapper.writeValueAsString(paths.toArray)
}
- val checkFilesExistsOption = DataSourceOptions.CHECK_FILES_EXIST_KEY ->
"true"
+ // TODO: remove this option.
+ val checkFilesExistsOption = "check_files_exist" -> "true"
Review comment:
Could you file a JIRA and make this as an IDed TODO please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
