vanzin commented on a change in pull request #23599: [SPARK-24793][K8s] Enhance
spark-submit for app management
URL: https://github.com/apache/spark/pull/23599#discussion_r263869823
##########
File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
##########
@@ -1358,3 +1387,12 @@ private case class OptionAssigner(
deployMode: Int,
clOption: String = null,
confKey: String = null)
+
+private[spark] trait SparkSubmitOperationsClient {
+
+ def kill(args: SparkSubmitArguments): Unit
Review comment:
I don't see that as sub-optimal, I see that as the goal. e.g. you're
providing what to kill as an argument to the method.
Even better if all that could be encoded in a URI, but the master URI syntax
was not really designed that way...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
