liupc commented on a change in pull request #24024: 
[core]spark.diskStore.subDirectories > 0 should throw Exception
URL: https://github.com/apache/spark/pull/24024#discussion_r263984114
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -301,6 +301,8 @@ package object config {
       .doc("Number of subdirectories inside each path listed in 
spark.local.dir for " +
         "hashing Block files into.")
       .intConf
+      .checkValue(_ > 0, "The number of subdirectories for put hashing Block 
files into " +
 
 Review comment:
   @lcqzte10192193  The PR title should also be fixed, How about "Ensure the 
value of `spark.diskStore.subDirectories` to be a positive number?" or 
something else. And you should also put the jira number in the PR title.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to