felixcheung commented on a change in pull request #23969: [SPARK-26920][R]
Deduplicate type checking across Arrow optimization in SparkR
URL: https://github.com/apache/spark/pull/23969#discussion_r263988908
##########
File path: R/pkg/R/types.R
##########
@@ -83,3 +83,38 @@ specialtypeshandle <- function(type) {
}
returntype
}
+
+# Helper function that checks supported types in Arrow.
+checkSchemaInArrow <- function(schema) {
+ stopifnot(inherits(schema, "structType"))
Review comment:
nit: this is kinda duplicated in the caller - yes but either we trust they
are calling it right or we double check here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]