Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3249#issuecomment-67398758
Sorry for the delay reviewing this, but I finally had time to take a more
thorough look at the code. I think this will be a really cool feature to have
but I think there is some work that still needs to be done in the analysis
rule. At a high level, I think what needs to be done is as follows: make sure
the sub tree is already analyzed, which should simplify some things. Second,
when possible we should be working with attributes in a way that uses
expression ids (i.e. using `AttributeSet` and `AttributeMap` when possible).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
