liupc commented on issue #23989: [SPARK-27073][CORE]Handling of IdleStateEvent causes the normal connection to close URL: https://github.com/apache/spark/pull/23989#issuecomment-471171220 @cxzl25 What if the instructions rearrangement happen? the execution order of updating `timeOfLastRequestNs` and adding to `outstandingRpcs` is not guaranteed. And without synchronization or volatile the updating result of `timeOfLastRequestNs` and `outstandingRpcs` may not be seen immediately in `TransportChannelHandler`. Even without above problems, I think this fix is a little bit tricky.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
