MaxGekk commented on issue #24030: [SPARK-27109][SQL] Refactoring of TimestampFormatter and DateFormatter URL: https://github.com/apache/spark/pull/24030#issuecomment-471194026 > but do you need to break these out into a method plus two private helpers? I would leave this to JIT. I just hope the private methods will be inlined if it is needed (they are hot). I can mix the methods to `parse()` if you do believe it makes sense.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
