vanzin commented on issue #23989: [SPARK-27073][CORE]Handling of IdleStateEvent causes the normal connection to close URL: https://github.com/apache/spark/pull/23989#issuecomment-471221180 `timeOfLastRequestNs` is an atomic so I'm pretty sure fencing takes care of avoiding any issues caused by instruction re-ordering. The fix is right because if makes the condition check things in the opposite order they are written. It solves this problem, but as I said it can cause another one, which is way more minor (just a spurious log message).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
