srowen commented on a change in pull request #24028: [SPARK-26917][SQL] Further
reduce locks in CacheManager
URL: https://github.com/apache/spark/pull/24028#discussion_r264020050
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala
##########
@@ -144,16 +144,10 @@ class CacheManager extends Logging {
} else {
_.sameResult(plan)
}
- val plansToUncache = mutable.Buffer[CachedData]()
- readLock {
- val it = cachedData.iterator()
- while (it.hasNext) {
- val cd = it.next()
- if (shouldRemove(cd.plan)) {
- plansToUncache += cd
- }
- }
+ val cachedDataCopy = readLock {
+ cachedData.asScala.clone()
}
+ val plansToUncache = cachedDataCopy.filter(cd => shouldRemove(cd.plan))
Review comment:
I suspect that it's the logic in `shouldRemove` that takes the time here,
and can be done without the lock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
