srowen commented on a change in pull request #24030: [SPARK-27109][SQL]
Refactoring of TimestampFormatter and DateFormatter
URL: https://github.com/apache/spark/pull/24030#discussion_r264067573
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -33,15 +32,15 @@ class Iso8601DateFormatter(
@transient
private lazy val formatter = getOrCreateFormatter(pattern, locale)
- private val UTC = ZoneId.of("UTC")
+ private val UTC = ZoneOffset.UTC
Review comment:
Not sure it matters, but this creates a field that always points to the same
static instance. Can you just reference ZoneOffset.UTC directly rather than
declare this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
