cloud-fan commented on a change in pull request #24025: [SPARK-27106][SQL]
merge CaseInsensitiveStringMap and DataSourceOptions
URL: https://github.com/apache/spark/pull/24025#discussion_r264084175
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/TextSocketSourceProvider.scala
##########
@@ -30,31 +30,32 @@ import org.apache.spark.sql.sources.v2._
import org.apache.spark.sql.sources.v2.reader.{Scan, ScanBuilder}
import org.apache.spark.sql.sources.v2.reader.streaming.{ContinuousStream,
MicroBatchStream}
import org.apache.spark.sql.types.{StringType, StructField, StructType,
TimestampType}
+import org.apache.spark.sql.util.CaseInsensitiveStringMap
class TextSocketSourceProvider extends TableProvider with DataSourceRegister
with Logging {
- private def checkParameters(params: DataSourceOptions): Unit = {
+ private def checkParameters(params: CaseInsensitiveStringMap): Unit = {
logWarning("The socket source should not be used for production
applications! " +
"It does not support recovery.")
- if (!params.get("host").isPresent) {
+ if (!params.containsKey("host")) {
throw new AnalysisException("Set a host to read from with
option(\"host\", ...).")
}
- if (!params.get("port").isPresent) {
+ if (!params.containsKey("port")) {
throw new AnalysisException("Set a port to read from with
option(\"port\", ...).")
}
Try {
- params.get("includeTimestamp").orElse("false").toBoolean
+ params.getBoolean("includeTimestamp", false)
} match {
case Success(_) =>
case Failure(_) =>
throw new AnalysisException("includeTimestamp must be set to either
\"true\" or \"false\"")
Review comment:
good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
