cloud-fan commented on a change in pull request #24012: [SPARK-26811][SQL] Add
capabilities to v2.Table
URL: https://github.com/apache/spark/pull/24012#discussion_r264099535
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/sources/v2/SupportsRead.java
##########
@@ -25,7 +25,7 @@
* {@link #newScanBuilder(DataSourceOptions)} that is used to create a scan
for batch, micro-batch,
* or continuous processing.
*/
-interface SupportsRead extends Table {
+public interface SupportsRead extends Table {
Review comment:
shall we remove this interface as well? We can move `newScanBuilder` to
table and throw exception by default. Tables that reports batch/stream scan
capability should overwrite `newScanBuilder`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
