viirya commented on a change in pull request #24053: [SPARK-27126][SQL] Consolidate Scala and Java type deserializerFor URL: https://github.com/apache/spark/pull/24053#discussion_r264189125
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/TypeInference.scala ########## @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst + +import java.util.{Map => JMap} + +import scala.collection.Map +import scala.language.existentials + +import com.google.common.reflect.TypeToken + +import org.apache.spark.sql.catalyst.DeserializerBuildHelper._ +import org.apache.spark.sql.catalyst.JavaTypeInference._ +import org.apache.spark.sql.catalyst.ScalaReflection._ +import org.apache.spark.sql.catalyst.ScalaReflection.universe._ +import org.apache.spark.sql.catalyst.expressions.{Expression, IsNull, MapKeys, MapValues} +import org.apache.spark.sql.catalyst.expressions.objects._ +import org.apache.spark.sql.catalyst.util.ArrayBasedMapData +import org.apache.spark.sql.types.{ObjectType, SQLUserDefinedType, UDTRegistration, UserDefinedType} + +object TypeInference { + + /** + * Returns an expression that can be used to deserialize an input expression to an object of type + * represented by an `TypeInference` with a compatible schema. + * + * @param t The `TypeInference` object providing type information. + * @param path The expression which can be used to extract serialized value. + * @param walkedTypePath The paths from top to bottom to access current field when deserializing. + */ + def deserializerFor( + t: TypeInference, + path: Expression, + walkedTypePath: WalkedTypePath): Expression = t match { + case _ if t.isNotObjectType => path + case _ if t.isJavaBoolean => + createDeserializerForTypesSupportValueOf(path, classOf[java.lang.Boolean]) + case _ if t.isJavaByte => + createDeserializerForTypesSupportValueOf(path, classOf[java.lang.Byte]) + case _ if t.isJavaInteger => + createDeserializerForTypesSupportValueOf(path, classOf[java.lang.Integer]) + case _ if t.isJavaLong => + createDeserializerForTypesSupportValueOf(path, classOf[java.lang.Long]) + case _ if t.isJavaDouble => + createDeserializerForTypesSupportValueOf(path, classOf[java.lang.Double]) + case _ if t.isJavaFloat => + createDeserializerForTypesSupportValueOf(path, classOf[java.lang.Float]) + case _ if t.isJavaShort => + createDeserializerForTypesSupportValueOf(path, classOf[java.lang.Short]) + case _ if t.isJavaLocalDate => + createDeserializerForLocalDate(path) + case _ if t.isJavaDate => + createDeserializerForSqlDate(path) + case _ if t.isJavaInstant => + createDeserializerForInstant(path) + case _ if t.isJavaTimestamp => + createDeserializerForSqlTimestamp(path) + case _ if t.isJavaString => + createDeserializerForString(path, returnNullable = false) + case _ if t.isJavaBigDecimal => + createDeserializerForJavaBigDecimal(path, returnNullable = false) + case _ if t.isScalaBigDecimal => + createDeserializerForScalaBigDecimal(path, returnNullable = false) + case _ if t.isJavaBigInteger => + createDeserializerForJavaBigInteger(path, returnNullable = false) + case _ if t.isScalaBigInt => + createDeserializerForScalaBigInt(path) + + case _ => t.deserializerFor(path, walkedTypePath) + } +} + +trait TypeInference { + + def isNotObjectType: Boolean = false + + def isJavaShort: Boolean = false + def isJavaInteger: Boolean = false + def isJavaLong: Boolean = false + def isJavaDouble: Boolean = false + def isJavaFloat: Boolean = false + def isJavaByte: Boolean = false + def isJavaBoolean: Boolean = false + + def isJavaLocalDate: Boolean = false + def isJavaDate: Boolean = false + def isJavaInstant: Boolean = false + def isJavaTimestamp: Boolean = false + def isJavaString: Boolean = false + def isJavaBigDecimal: Boolean = false + def isJavaBigInteger: Boolean = false + + def isScalaBigDecimal: Boolean = false + def isScalaBigInt: Boolean = false + + /** + * Defines deserializers for specified `TypeInference`. + */ + def deserializerFor(path: Expression, walkedTypePath: WalkedTypePath): Expression +} + +case class ScalaInference(scalaType: `Type`) extends TypeInference { + + val t = scalaType.dealias + + override def isNotObjectType: Boolean = !dataTypeFor(t).isInstanceOf[ObjectType] + + override def isJavaShort: Boolean = t <:< localTypeOf[java.lang.Short] + override def isJavaInteger: Boolean = t <:< localTypeOf[java.lang.Integer] + override def isJavaLong: Boolean = t <:< localTypeOf[java.lang.Long] + override def isJavaDouble: Boolean = t <:< localTypeOf[java.lang.Double] + override def isJavaFloat: Boolean = t <:< localTypeOf[java.lang.Float] + override def isJavaByte: Boolean = t <:< localTypeOf[java.lang.Byte] + override def isJavaBoolean: Boolean = t <:< localTypeOf[java.lang.Boolean] + + override def isJavaLocalDate: Boolean = t <:< localTypeOf[java.time.LocalDate] + override def isJavaDate: Boolean = t <:< localTypeOf[java.sql.Date] + override def isJavaInstant: Boolean = t <:< localTypeOf[java.time.Instant] + override def isJavaTimestamp: Boolean = t <:< localTypeOf[java.sql.Timestamp] + override def isJavaString: Boolean = t <:< localTypeOf[java.lang.String] + override def isJavaBigDecimal: Boolean = t <:< localTypeOf[java.math.BigDecimal] + override def isJavaBigInteger: Boolean = t <:< localTypeOf[java.math.BigInteger] + + override def isScalaBigDecimal: Boolean = t <:< localTypeOf[BigDecimal] + override def isScalaBigInt: Boolean = t <:< localTypeOf[scala.math.BigInt] + + def isSQLUserDefinedType: Boolean = + t.typeSymbol.annotations.exists(_.tree.tpe =:= typeOf[SQLUserDefinedType]) + def isRegisteredUDT: Boolean = UDTRegistration.exists(getClassNameFromType(t)) + + def isScalaArray: Boolean = t <:< localTypeOf[Array[_]] + def isScalaOption: Boolean = t <:< localTypeOf[Option[_]] + def isScalaSeq: Boolean = t <:< localTypeOf[Seq[_]] + def isScalaSet: Boolean = t <:< localTypeOf[scala.collection.Set[_]] + def isScalaMap: Boolean = t <:< localTypeOf[Map[_, _]] + def isDefinedByConstructorParams: Boolean = ScalaReflection.definedByConstructorParams(t) + + override def deserializerFor( + path: Expression, + walkedTypePath: WalkedTypePath): Expression = this match { + case _ if isScalaOption => + val TypeRef(_, _, Seq(optType)) = t + val className = getClassNameFromType(optType) + val newTypePath = walkedTypePath.recordOption(className) + WrapOption(TypeInference.deserializerFor(ScalaInference(optType), path, newTypePath), + dataTypeFor(optType)) + + case _ if isScalaArray => Review comment: I feel this can be consolidated further with Java's array and list cases. But not do it now in order to reduce diff. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
