srowen commented on issue #24056: [SPARK-26152] Synchronize Worker Cleanup with 
Worker Shutdown
URL: https://github.com/apache/spark/pull/24056#issuecomment-471571998
 
 
   I don't think the synchronized block changes anything. `onStop()` still 
races with the submission of the cleanup task (which itself sounds weird, but 
maybe separate). `if (!cleanupThreadExecutor.isShutdown)` makes sense to me to 
avoid the exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to