srowen commented on a change in pull request #24016: [MINOR][SQL] Deduplicate huge if statements in get between specialized getters URL: https://github.com/apache/spark/pull/24016#discussion_r264272805
########## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/SpecializedGettersReader.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions; + +import org.apache.spark.sql.types.*; + +public class SpecializedGettersReader { + private final boolean handleNull; + private final boolean handleUserDefinedType; + + public SpecializedGettersReader(boolean handleNull, boolean handleUserDefinedType) { + this.handleNull = handleNull; + this.handleUserDefinedType = handleUserDefinedType; + } + + public Object read(SpecializedGetters obj, int ordinal, DataType dataType) { + if (handleNull && (obj.isNullAt(ordinal) || dataType instanceof NullType)) { + return null; + } else if (dataType instanceof BooleanType) { Review comment: Nit: all the 'else's are redundant. It won't make a difference in the bytecode and isn't a big deal, just feels more readable to me if there are going to be 20 of them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
