dilipbiswal opened a new pull request #24060: [SPARK-27016][SQL][BUILD][SBT][FOLLOW-UP] Treat all antlr warnings as errors while generating the parser. URL: https://github.com/apache/spark/pull/24060 ## What changes were proposed in this pull request? Use the sbt maven plugin option`antlr4TreatWarningsAsErrors` to make sure the warnings are treated as errors while generating the parser. In the absence of it, we may inadvertently introduce problems while making grammar changes. Please refer to PR-23897 to know more about the context. We made a change in [pr-23925](https://github.com/apache/spark/pull/23925) which handled only the maven build. In this PR, we handle the sbt build. I had submitted [PR-23](https://github.com/ihji/sbt-antlr4/pull/23) to enhance the sbt-antlr plugin to make is possible to pass the error on warning option. ## How was this patch tested? Force an warning in the grammar file to check if the build fails. Then remove the warning to verify the build succeeds.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
