srowen commented on a change in pull request #23983: [SPARK-26881][mllib]
Heuristic for tree aggregate depth
URL: https://github.com/apache/spark/pull/23983#discussion_r264479693
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala
##########
@@ -24,8 +24,8 @@ import scala.collection.mutable.ListBuffer
import breeze.linalg.{axpy => brzAxpy, inv, svd => brzSvd, DenseMatrix => BDM,
DenseVector => BDV,
MatrixSingularException, SparseVector => BSV}
import breeze.numerics.{sqrt => brzSqrt}
-
import org.apache.spark.annotation.Since
+import org.apache.spark.internal.config.MAX_RESULT_SIZE
Review comment:
The style checker is picky:
```
[error]
/home/jenkins/workspace/NewSparkPullRequestBuilder/mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala:27:0:
There should at least one a single empty line separating groups 3rdParty and
spark.
[error]
/home/jenkins/workspace/NewSparkPullRequestBuilder/mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/RowMatrix.scala:29:0:
org.apache.spark.internal.Logging is in wrong order relative to
org.apache.spark.internal.config.MAX_RESULT_SIZE.
[error] Total time: 18 s, completed Mar 11, 2019 6:05:24 AM
```
I think you need to restore the blank line, and move this import below the
following one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
