srowen commented on a change in pull request #24065: [SPARK-27130][BUILD]
Automatically select profile when executing sbt-checkstyle
URL: https://github.com/apache/spark/pull/24065#discussion_r264688636
##########
File path: dev/sbt-checkstyle
##########
@@ -17,17 +17,13 @@
# limitations under the License.
#
+build_profiles=$1
+echo "Checking Spark style using SBT with these arguments: ${build_profiles}"
+
# NOTE: echo "q" is needed because SBT prompts the user for input on
encountering a build file
# with failure (either resolution or compilation); the "q" makes SBT quit.
ERRORS=$(echo -e "q\n" \
- | build/sbt \
- -Pkinesis-asl \
- -Pmesos \
- -Pkubernetes \
- -Pyarn \
- -Phive \
- -Phive-thriftserver \
- checkstyle test:checkstyle \
Review comment:
I think that is what the `${1:-...}` syntax does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
