srowen commented on a change in pull request #23758: [SPARK-17454][MESOS] Use Mesos disk resources for executors. URL: https://github.com/apache/spark/pull/23758#discussion_r264720462
########## File path: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala ########## @@ -79,6 +79,7 @@ private[spark] class MesosCoarseGrainedSchedulerBackend( private val useFetcherCache = conf.get(ENABLE_FETCHER_CACHE) private val maxGpus = conf.get(MAX_GPUS) + private val diskPerExecutor = conf.get(EXECUTOR_DISK) Review comment: I think this throws an exception if not set, and it's optional. You can either check `.contains` here and make this an Option, or have a default value of '0' or something that would indicate no reservation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
