maropu commented on issue #24049: [SPARK-27123][SQL] Improve CollapseProject to 
handle projects cross limit/repartition/sample
URL: https://github.com/apache/spark/pull/24049#issuecomment-472204688
 
 
   Sorry to be late; could you update the description of `CollapseProject` as 
follow-up?
   ```
   /**
    * Combines two adjacent [[Project]] operators into one and perform alias 
substitution,
    * merging the expressions into one single expression.
    */
   ```
   Probably, it would be better to describe something about the new target this 
pr added. It seems `Project -> Sample -> Project` is not a case of adjacent 
projects? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to