liupc commented on a change in pull request #23845: [SPARK-26941][YARN]Fix
incorrect computation of maxNumExecutorFailures in ApplicationMaster for
streaming
URL: https://github.com/apache/spark/pull/23845#discussion_r264947616
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -332,6 +332,51 @@ package object config {
ConfigBuilder("spark.dynamicAllocation.sustainedSchedulerBacklogTimeout")
.fallbackConf(DYN_ALLOCATION_SCHEDULER_BACKLOG_TIMEOUT)
+ private[spark] val STREAMING_DYN_ALLOCATION_ENABLED =
Review comment:
@vanzin
> If for some reason that is allowed, then the fix should take the max of
both values.
This is not allowed to enable both of them. This check is done in the
`scheduler/ExecutorAllocationManager`
https://github.com/apache/spark/blob/7beb464564a04004c638d6b0e1d8aafd9f038a0a/streaming/src/main/scala/org/apache/spark/streaming/scheduler/ExecutorAllocationManager.scala#L211
I agree to put these configs to `Streaming.scala`, it's more clear. I will
update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
