zjf2012 commented on a change in pull request #23560: [SPARK-26632][Core]
Separate Thread Configurations of Driver and Executor
URL: https://github.com/apache/spark/pull/23560#discussion_r264988473
##########
File path:
core/src/main/scala/org/apache/spark/network/netty/SparkTransportConf.scala
##########
@@ -31,21 +31,27 @@ object SparkTransportConf {
/**
* Utility for creating a [[TransportConf]] from a [[SparkConf]].
- * @param _conf the [[SparkConf]]
- * @param module the module name
+ * @param _conf the [[SparkConf]]
+ * @param module the module name
* @param numUsableCores if nonzero, this will restrict the server and
client threads to only
* use the given number of cores, rather than all of
the machine's cores.
* This restriction will only occur if these
properties are not already set.
+ * @param role optional role, could be driver, executor, worker
and master. Default is
+ * [[None]], means no role specific configurations.
*/
- def fromSparkConf(_conf: SparkConf, module: String, numUsableCores: Int =
0): TransportConf = {
+ def fromSparkConf(
+ _conf: SparkConf,
+ module: String,
+ numUsableCores: Int = 0,
+ role: Option[String] = None): TransportConf = {
val conf = _conf.clone
-
- // Specify thread configuration based on our JVM's allocation of cores
(rather than necessarily
- // assuming we have all the machine's cores).
- // NB: Only set if serverThreads/clientThreads not already set.
+ val (serverThreads, clientThreads) = getThreadsConfByRole(conf, module,
role)
Review comment:
re-structured code as discussed. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
