MaxGekk commented on issue #20793: [WIP][SPARK-23643] Shrinking the buffer in 
hashSeed up to size of the seed parameter
URL: https://github.com/apache/spark/pull/20793#issuecomment-472608155
 
 
   @shahidki31 Other tests fail because they depend on a seed for random 
generator. And those test I can fix just by replacing expected results. ... but 
I cannot fix the test I point out in the same way. I would guess if test checks 
`assert(Set(predictions2(0).size, predictions2(1).size) !== Set(2, 3)) ` then 
it must not depend on random generator. If it depends on a seed for random, 
there must be a way to regenerate input for the tests. Here I don't see how I 
can impact on the test. It looks like it passes only for particular random's 
seed, and fails for others. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to