squito commented on issue #23951: [SPARK-27038][CORE][YARN] Re-implement 
RackResolver to reduce resolving time
URL: https://github.com/apache/spark/pull/23951#issuecomment-472619102
 
 
   btw I just noticed that dynamic allocation may still suffer with rack 
resolution even after this fix, if YARN-9332 isn't in, because 
`AMRMClientImpl.addContainerRequest()` will resolve the racks again:
   
   
https://github.com/apache/hadoop/blob/6fa229891e06eea62cb9634efde755f40247e816/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java#L550
   
   which is called here in Spark:
   
   
https://github.com/apache/spark/blob/733f2c0b98208815f8408e36ab669d7c07e3767f/resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala#L361-L363
   
   I'm not sure if there is anything better Spark can do about this, but wanted 
to mention it while I saw it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to