dongjoon-hyun commented on a change in pull request #24081: [SPARK-27151][SQL]
ClearCacheCommand should be case-object to avoid copys
URL: https://github.com/apache/spark/pull/24081#discussion_r265350815
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/cache.scala
##########
@@ -83,13 +83,10 @@ case class UncacheTableCommand(
/**
* Clear all cached data from the in-memory cache.
*/
-case class ClearCacheCommand() extends RunnableCommand {
+case object ClearCacheCommand extends RunnableCommand with IgnoreCachedData {
Review comment:
Hi, @maropu .
The purpose and title doesn't match. What you want is `IgnoreCahedData` and
the test case, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]