rdblue commented on a change in pull request #24029: SPARK-27108: Add parsed
SQL plans for create, CTAS.
URL: https://github.com/apache/spark/pull/24029#discussion_r265357623
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -376,128 +376,46 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
DescribeQueryCommand(visitQueryToDesc(ctx.queryToDesc()))
}
- /**
- * Type to keep track of a table header: (identifier, isTemporary,
ifNotExists, isExternal).
- */
- type TableHeader = (TableIdentifier, Boolean, Boolean, Boolean)
-
- /**
- * Validate a create table statement and return the [[TableIdentifier]].
- */
- override def visitCreateTableHeader(
- ctx: CreateTableHeaderContext): TableHeader = withOrigin(ctx) {
- val temporary = ctx.TEMPORARY != null
- val ifNotExists = ctx.EXISTS != null
- if (temporary && ifNotExists) {
- operationNotAllowed("CREATE TEMPORARY TABLE ... IF NOT EXISTS", ctx)
- }
- (visitTableIdentifier(ctx.tableIdentifier), temporary, ifNotExists,
ctx.EXTERNAL != null)
- }
-
/**
* Create a table, returning a [[CreateTable]] logical plan.
*
- * Expected format:
- * {{{
- * CREATE [TEMPORARY] TABLE [IF NOT EXISTS] [db_name.]table_name
- * USING table_provider
- * create_table_clauses
- * [[AS] select_statement];
+ * This is used to produce CreateTempViewUsing from CREATE TEMPORARY TABLE.
*
- * create_table_clauses (order insensitive):
- * [OPTIONS table_property_list]
- * [PARTITIONED BY (col_name, col_name, ...)]
- * [CLUSTERED BY (col_name, col_name, ...)
- * [SORTED BY (col_name [ASC|DESC], ...)]
- * INTO num_buckets BUCKETS
- * ]
- * [LOCATION path]
- * [COMMENT table_comment]
- * [TBLPROPERTIES (property_name=property_value, ...)]
- * }}}
+ * TODO: Remove this. It is used because CreateTempViewUsing is not a
Catalyst plan.
+ * Either move CreateTempViewUsing into catalyst as a parsed logical plan,
or remove it because
+ * it is deprecated.
Review comment:
Looks like it happened in 5effc016c893ce917d535cc1b5026d8e4c846721, 3 years
ago.
We can always create a parsed plan for `CreateTempViewUsing` so that it can
move to catalyst as well, but I thought that we can do it later, and only need
to if this isn't going to be removed in 3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
