rdblue edited a comment on issue #24029: SPARK-27108: Add parsed SQL plans for create, CTAS. URL: https://github.com/apache/spark/pull/24029#issuecomment-472639088 @cloud-fan, I've responded to the review comments and implemented fixes. Also, I moved the new resolution rules into `DataSourceResolution` to fix the test failures. The new rules needed to be added to `extendedResolutionRules` instead of `postHocResolutionRules` because the post-hoc rules are only run once. This resolution needs to be done before the post-hoc rules defined in `DataSourceAnalysis` run. At a minimum, these needed to be separated into different classes, but I think it is also more correct for resolution rules to run in the resolution batch so that other resolution rules can run on the plans produced by these rules. This is the same reason why we added the `ResolveOutputRelation` rule to the resolution batch. I think that the resolution rules in `DataSourceAnalysis` should also move into the resolution batch, but that should be done as a separate change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
