wangyum commented on a change in pull request #24089: [SPARK-27158][BUILD]
dev/mima and dev/scalastyle support dynamic profiles
URL: https://github.com/apache/spark/pull/24089#discussion_r265474250
##########
File path: dev/run-tests.py
##########
@@ -359,7 +361,10 @@ def build_apache_spark(build_tool, hadoop_version):
def detect_binary_inop_with_mima(hadoop_version):
build_profiles = get_hadoop_profiles(hadoop_version) +
modules.root.build_profile_flags
set_title_and_block("Detecting binary incompatibilities with MiMa",
"BLOCK_MIMA")
- run_cmd([os.path.join(SPARK_HOME, "dev", "mima")] + build_profiles)
+ profiles = " ".join(build_profiles)
+ print("[info] Detecting binary incompatibilities with MiMa using SBT with
these profiles: ",
+ profiles)
+ run_cmd([os.path.join(SPARK_HOME, "dev", "mima"), profiles])
Review comment:
`run_cmd([os.path.join(SPARK_HOME, "dev", "mima"), profiles])` could get all
args by `$1`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
