attilapiros commented on a change in pull request #24079: 
[SPARK-27145][Minor]Close store  in the SQLAppStatusListenerSuite after test
URL: https://github.com/apache/spark/pull/24079#discussion_r265559743
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
 ##########
 @@ -55,12 +55,10 @@ class SQLAppStatusListenerSuite extends SparkFunSuite with 
SharedSQLContext with
 
   private var kvstore: ElementTrackingStore = _
 
-  before {
-    kvstore = new ElementTrackingStore(new InMemoryStore, sparkContext.conf)
-  }
-
   after {
-    kvstore.close()
+    if (kvstore != null) {
+      kvstore.close()
 
 Review comment:
   After calling close please release the store too: set kvstore to null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to